From 3c11fd20677e93bd9cfc2d120950ba459d2531ec Mon Sep 17 00:00:00 2001
From: Philip Guzman III <pguzman@theguzmanfamily.com>
Date: Wed, 13 May 2026 21:06:03 -0700
Subject: [PATCH] Fix modal visibility using CSS class instead of HTML hidden
 attribute

Replace hidden attribute + [hidden] CSS selector with a .modal-open
class toggle. The hidden attribute approach was unreliable because
CSS display:flex was winning the specificity battle. Class-based
show/hide is explicit and not subject to attribute/cascade conflicts.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 admin/builder.php      | 2 +-
 assets/css/builder.css | 8 +++++---
 assets/js/builder.js   | 4 ++--
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/admin/builder.php b/admin/builder.php
index 0ab7beb..ae09ef2 100644
--- a/admin/builder.php
+++ b/admin/builder.php
@@ -184,7 +184,7 @@ $page_title = $session ? 'Edit: ' . htmlspecialchars($session['name']) : 'Rosary
 
 
 <!-- ── Create / Edit Prayer Modal ─────────────────────────────── -->
-<div id="prayer-modal" class="modal-overlay" hidden>
+<div id="prayer-modal" class="modal-overlay">
     <div class="modal-box">
         <h3 id="modal-title">New Custom Prayer</h3>
 
diff --git a/assets/css/builder.css b/assets/css/builder.css
index 27c9d58..94163bd 100644
--- a/assets/css/builder.css
+++ b/assets/css/builder.css
@@ -461,19 +461,21 @@
 
 /* ── Modal ───────────────────────────────────────────────────── */
 
-.modal-overlay[hidden] { display: none; }
-
 .modal-overlay {
+    display: none; /* hidden by default; JS adds .modal-open to show */
     position: fixed;
     inset: 0;
     background: rgba(0,0,0,0.45);
     z-index: 1000;
-    display: flex;
     align-items: center;
     justify-content: center;
     padding: 20px;
 }
 
+.modal-overlay.modal-open {
+    display: flex;
+}
+
 .modal-box {
     background: var(--bg-card);
     border-radius: 12px;
diff --git a/assets/js/builder.js b/assets/js/builder.js
index a4ef4b8..499394c 100644
--- a/assets/js/builder.js
+++ b/assets/js/builder.js
@@ -257,12 +257,12 @@
 
         updateModalFields();
         updateAttrRadioStyles();
-        modal.hidden = false;
+        modal.classList.add('modal-open');
         document.getElementById('modal-name').focus();
     }
 
     function closeModal() {
-        document.getElementById('prayer-modal').hidden = true;
+        document.getElementById('prayer-modal').classList.remove('modal-open');
         editingPrayerId = null;
     }