Consolidate schema, add CSRF protection, and add login rate-limiting
Six fixes from a codebase review: - Consolidate the ad hoc install.php + migrate_v2..v6.php chain into one canonical schema.sql (structure reference) plus a simplified install.php that creates all tables and seeds site_settings, the superadmin account, and the standard prayer library. The six migrate_v*.php scripts are deleted — their cumulative effect is now fully captured in schema.sql. - Delete the two root-level setup.php/novena_group.php files that existed only to redirect to their admin/ equivalents of the same name; confirmed unreferenced by any link or .htaccess rule. - Decouple includes/build_slides.php from data/prayers.php's implicit `global $opening, $mysteries, ...` contract. data/prayers.php now explicitly returns its arrays; build_slides.php loads them through a small memoized get_prayer_data() and destructures them by key. - Add CSRF protection (includes/csrf.php: csrf_token/csrf_field/csrf_verify) across every POST-handling endpoint — 10 form pages and 7 API endpoints — plus token wiring in the JS/inline scripts that call the FormData- and JSON-body API endpoints (builder.js, setup.js, and the inline scripts in admin/audio.php, admin/novena_group.php, and index.php). - Stop round-tripping the SMTP password in plaintext through the settings form: the field now renders blank with a "currently set" hint, and a blank submission leaves the stored password unchanged instead of clearing it. - Add login rate-limiting: users.failed_login_attempts / locked_until columns, is_locked_out()/record_login_failure()/record_login_success() helpers in includes/auth.php, and lockout handling in login.php (5 failed attempts locks the account for 15 minutes). README documents the one manual ALTER TABLE needed to add these columns to an existing production database. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -66,3 +66,40 @@ function can_create_rosary(int $user_id, int $limit): bool {
|
||||
$st->execute([$user_id, $user_id]);
|
||||
return (int)$st->fetchColumn() < $limit;
|
||||
}
|
||||
|
||||
const LOGIN_LOCKOUT_THRESHOLD = 5;
|
||||
const LOGIN_LOCKOUT_MINUTES = 15;
|
||||
|
||||
/** True if this user account is currently locked out from login attempts. */
|
||||
function is_locked_out(array $user): bool {
|
||||
if (empty($user['locked_until'])) return false;
|
||||
return strtotime($user['locked_until']) > time();
|
||||
}
|
||||
|
||||
/** Minutes remaining until a locked-out account can try again (0 if not locked). */
|
||||
function login_lockout_minutes_remaining(array $user): int {
|
||||
if (!is_locked_out($user)) return 0;
|
||||
return (int)ceil((strtotime($user['locked_until']) - time()) / 60);
|
||||
}
|
||||
|
||||
/** Record a failed login attempt; locks the account after LOGIN_LOCKOUT_THRESHOLD attempts. */
|
||||
function record_login_failure(int $user_id): void {
|
||||
$pdo = get_pdo();
|
||||
$pdo->prepare('UPDATE users SET failed_login_attempts = failed_login_attempts + 1 WHERE id = ?')
|
||||
->execute([$user_id]);
|
||||
|
||||
$st = $pdo->prepare('SELECT failed_login_attempts FROM users WHERE id = ?');
|
||||
$st->execute([$user_id]);
|
||||
$attempts = (int)$st->fetchColumn();
|
||||
|
||||
if ($attempts >= LOGIN_LOCKOUT_THRESHOLD) {
|
||||
$locked_until = date('Y-m-d H:i:s', time() + LOGIN_LOCKOUT_MINUTES * 60);
|
||||
$pdo->prepare('UPDATE users SET locked_until = ? WHERE id = ?')->execute([$locked_until, $user_id]);
|
||||
}
|
||||
}
|
||||
|
||||
/** Reset the failed-attempt counter and any lockout after a successful login. */
|
||||
function record_login_success(int $user_id): void {
|
||||
get_pdo()->prepare('UPDATE users SET failed_login_attempts = 0, locked_until = NULL WHERE id = ?')
|
||||
->execute([$user_id]);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user