pguzman
9622f9aeca
Six fixes from a codebase review: - Consolidate the ad hoc install.php + migrate_v2..v6.php chain into one canonical schema.sql (structure reference) plus a simplified install.php that creates all tables and seeds site_settings, the superadmin account, and the standard prayer library. The six migrate_v*.php scripts are deleted — their cumulative effect is now fully captured in schema.sql. - Delete the two root-level setup.php/novena_group.php files that existed only to redirect to their admin/ equivalents of the same name; confirmed unreferenced by any link or .htaccess rule. - Decouple includes/build_slides.php from data/prayers.php's implicit `global $opening, $mysteries, ...` contract. data/prayers.php now explicitly returns its arrays; build_slides.php loads them through a small memoized get_prayer_data() and destructures them by key. - Add CSRF protection (includes/csrf.php: csrf_token/csrf_field/csrf_verify) across every POST-handling endpoint — 10 form pages and 7 API endpoints — plus token wiring in the JS/inline scripts that call the FormData- and JSON-body API endpoints (builder.js, setup.js, and the inline scripts in admin/audio.php, admin/novena_group.php, and index.php). - Stop round-tripping the SMTP password in plaintext through the settings form: the field now renders blank with a "currently set" hint, and a blank submission leaves the stored password unchanged instead of clearing it. - Add login rate-limiting: users.failed_login_attempts / locked_until columns, is_locked_out()/record_login_failure()/record_login_success() helpers in includes/auth.php, and lockout handling in login.php (5 failed attempts locks the account for 15 minutes). README documents the one manual ALTER TABLE needed to add these columns to an existing production database. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
68 lines
1.6 KiB
PHP
68 lines
1.6 KiB
PHP
<?php
|
|
/**
|
|
* api/toggle_pin.php
|
|
* POST: toggle is_pinned on a session or novena_group.
|
|
* Admin / superadmin only.
|
|
*
|
|
* POST params:
|
|
* type — 'session' | 'novena'
|
|
* id — integer row ID
|
|
*
|
|
* Returns JSON: {"pinned": true|false}
|
|
*/
|
|
require_once __DIR__ . '/../config/db.php';
|
|
require_once __DIR__ . '/../includes/auth.php';
|
|
require_once __DIR__ . '/../includes/csrf.php';
|
|
|
|
header('Content-Type: application/json');
|
|
|
|
_auth_start();
|
|
|
|
if (!has_role('admin')) {
|
|
http_response_code(403);
|
|
echo json_encode(['error' => 'Permission denied']);
|
|
exit;
|
|
}
|
|
|
|
if ($_SERVER['REQUEST_METHOD'] !== 'POST') {
|
|
http_response_code(405);
|
|
echo json_encode(['error' => 'Method not allowed']);
|
|
exit;
|
|
}
|
|
|
|
csrf_verify();
|
|
|
|
$type = trim($_POST['type'] ?? '');
|
|
$id = (int)($_POST['id'] ?? 0);
|
|
|
|
if (!in_array($type, ['session', 'novena'], true) || $id < 1) {
|
|
http_response_code(400);
|
|
echo json_encode(['error' => 'Invalid parameters']);
|
|
exit;
|
|
}
|
|
|
|
try {
|
|
$pdo = get_pdo();
|
|
$table = ($type === 'session') ? 'sessions' : 'novena_groups';
|
|
|
|
$sel = $pdo->prepare("SELECT is_pinned FROM {$table} WHERE id = ?");
|
|
$sel->execute([$id]);
|
|
$row = $sel->fetch();
|
|
|
|
if (!$row) {
|
|
http_response_code(404);
|
|
echo json_encode(['error' => 'Record not found']);
|
|
exit;
|
|
}
|
|
|
|
$new = $row['is_pinned'] ? 0 : 1;
|
|
$upd = $pdo->prepare("UPDATE {$table} SET is_pinned = ? WHERE id = ?");
|
|
$upd->execute([$new, $id]);
|
|
|
|
echo json_encode(['pinned' => (bool)$new]);
|
|
|
|
} catch (PDOException $e) {
|
|
http_response_code(500);
|
|
echo json_encode(['error' => 'Database error']);
|
|
}
|