pguzman
9622f9aeca
Six fixes from a codebase review: - Consolidate the ad hoc install.php + migrate_v2..v6.php chain into one canonical schema.sql (structure reference) plus a simplified install.php that creates all tables and seeds site_settings, the superadmin account, and the standard prayer library. The six migrate_v*.php scripts are deleted — their cumulative effect is now fully captured in schema.sql. - Delete the two root-level setup.php/novena_group.php files that existed only to redirect to their admin/ equivalents of the same name; confirmed unreferenced by any link or .htaccess rule. - Decouple includes/build_slides.php from data/prayers.php's implicit `global $opening, $mysteries, ...` contract. data/prayers.php now explicitly returns its arrays; build_slides.php loads them through a small memoized get_prayer_data() and destructures them by key. - Add CSRF protection (includes/csrf.php: csrf_token/csrf_field/csrf_verify) across every POST-handling endpoint — 10 form pages and 7 API endpoints — plus token wiring in the JS/inline scripts that call the FormData- and JSON-body API endpoints (builder.js, setup.js, and the inline scripts in admin/audio.php, admin/novena_group.php, and index.php). - Stop round-tripping the SMTP password in plaintext through the settings form: the field now renders blank with a "currently set" hint, and a blank submission leaves the stored password unchanged instead of clearing it. - Add login rate-limiting: users.failed_login_attempts / locked_until columns, is_locked_out()/record_login_failure()/record_login_success() helpers in includes/auth.php, and lockout handling in login.php (5 failed attempts locks the account for 15 minutes). README documents the one manual ALTER TABLE needed to add these columns to an existing production database. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
82 lines
2.4 KiB
PHP
82 lines
2.4 KiB
PHP
<?php
|
|
/**
|
|
* api/upload_photo.php
|
|
* POST: handle photo upload.
|
|
* Returns JSON: {"path": "uploads/filename.jpg"} on success, {"error": "..."} on failure.
|
|
*/
|
|
require_once __DIR__ . '/../config/db.php';
|
|
require_once __DIR__ . '/../includes/auth.php';
|
|
require_once __DIR__ . '/../includes/csrf.php';
|
|
|
|
header('Content-Type: application/json');
|
|
|
|
require_auth();
|
|
|
|
if ($_SERVER['REQUEST_METHOD'] !== 'POST') {
|
|
http_response_code(405);
|
|
echo json_encode(['error' => 'Method not allowed']);
|
|
exit;
|
|
}
|
|
|
|
csrf_verify();
|
|
|
|
if (!isset($_FILES['photo']) || $_FILES['photo']['error'] !== UPLOAD_ERR_OK) {
|
|
$upload_errors = [
|
|
UPLOAD_ERR_INI_SIZE => 'File exceeds server upload limit',
|
|
UPLOAD_ERR_FORM_SIZE => 'File exceeds form size limit',
|
|
UPLOAD_ERR_PARTIAL => 'File was only partially uploaded',
|
|
UPLOAD_ERR_NO_FILE => 'No file was uploaded',
|
|
UPLOAD_ERR_NO_TMP_DIR => 'Missing temporary folder',
|
|
UPLOAD_ERR_CANT_WRITE => 'Failed to write file to disk',
|
|
UPLOAD_ERR_EXTENSION => 'A PHP extension stopped the upload',
|
|
];
|
|
$err_code = $_FILES['photo']['error'] ?? UPLOAD_ERR_NO_FILE;
|
|
$err_msg = $upload_errors[$err_code] ?? 'Unknown upload error';
|
|
http_response_code(400);
|
|
echo json_encode(['error' => $err_msg]);
|
|
exit;
|
|
}
|
|
|
|
$file = $_FILES['photo'];
|
|
$max_size = 5 * 1024 * 1024; // 5 MB
|
|
|
|
// Validate file size
|
|
if ($file['size'] > $max_size) {
|
|
http_response_code(400);
|
|
echo json_encode(['error' => 'File is too large (max 5 MB)']);
|
|
exit;
|
|
}
|
|
|
|
// Validate MIME type using finfo (not just extension)
|
|
$finfo = new finfo(FILEINFO_MIME_TYPE);
|
|
$mime = $finfo->file($file['tmp_name']);
|
|
$allowed = ['image/jpeg', 'image/png', 'image/gif', 'image/webp'];
|
|
|
|
if (!in_array($mime, $allowed, true)) {
|
|
http_response_code(400);
|
|
echo json_encode(['error' => 'Invalid file type. Allowed: JPEG, PNG, GIF, WebP']);
|
|
exit;
|
|
}
|
|
|
|
$ext_map = [
|
|
'image/jpeg' => 'jpg',
|
|
'image/png' => 'png',
|
|
'image/gif' => 'gif',
|
|
'image/webp' => 'webp',
|
|
];
|
|
$ext = $ext_map[$mime];
|
|
$filename = bin2hex(random_bytes(16)) . '.' . $ext;
|
|
$dest = UPLOADS_DIR . $filename;
|
|
|
|
if (!is_dir(UPLOADS_DIR)) {
|
|
mkdir(UPLOADS_DIR, 0755, true);
|
|
}
|
|
|
|
if (!move_uploaded_file($file['tmp_name'], $dest)) {
|
|
http_response_code(500);
|
|
echo json_encode(['error' => 'Failed to save file']);
|
|
exit;
|
|
}
|
|
|
|
echo json_encode(['path' => UPLOADS_URL . $filename]);
|